Fix: The default name of the operator does not include a numeric suffix.

[cike8899]

Summary

Fix: The default name of the operator does not include a numeric suffix.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e142bdc5-d89e-40f0-b2a9-ff4b7131cec5

📥 Commits

Reviewing files that changed from the base of the PR and between c0405a9 and 1ece345.

📒 Files selected for processing (3)

• web/src/pages/agent/empty-dsl.ts
• web/src/pages/agent/utils.test.ts
• web/src/pages/agent/utils.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The change aligns the empty dataflow DSL with the node-name generator. Parser nodes now use Parser for index zero. The generator recognizes this name and preserves existing suffix, gap-filling, legacy, type-filtering, and non-indexed-name behavior through new tests.

Changes

Parser naming

Layer / File(s)	Summary
Base-name generation and validation web/src/pages/agent/utils.ts, web/src/pages/agent/utils.test.ts, web/src/pages/agent/empty-dsl.ts	generateNodeNamesWithIncreasingIndex treats the base name as index zero and returns it without a suffix. Tests cover index allocation and filtering. The empty DSL changes the Parser node name from Parser_0 to Parser.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 1ece3

New empty agent graphs use Parser for the first Parser node, and subsequent nodes retain indexed naming. The covered naming and compatibility cases show no remaining merge-blocking risk.

Suggested reviewers: euvre

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: the default operator name no longer includes a numeric suffix. This matches the code and tests.
Description check	✅ Passed	The description includes the required Summary section and states the purpose of the change. It provides limited background context, but the missing detail is non-critical.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit hops where Parser names now flow
Base names bloom at index zero
Suffixes wait for nodes that grow
Gaps fill neatly in the row
Tests thump softly: all systems go}

_{Comment @coderabbitai help to get the list of available commands.}

[wangq8]

This is an AI review comment.

The change is clean and the test coverage is good. generateNodeNamesWithIncreasingIndex now emits the bare name for the first operator of a type and Name_1, Name_2, … afterwards, with correct gap-filling and legacy _0 handling. I traced all six new test cases against the implementation and the expected outputs are correct.

Minor observations (non-blocking):

1. DataflowEmptyDsl updates the seed Parser node from Parser_0 → Parser; the empty-DSL File node already uses the bare name File, so the two are now consistent. Good.

2. generateNodeNamesWithIncreasingIndex still keys off x.data.name only, not the node's label/operator type. A node of a different operator whose data.name happens to equal the requested name would be counted toward the index. This is pre-existing behavior (not a regression), so just flagging it — fine if names are guaranteed unique-per-operator.

Otherwise LGTM.

This is an AI review comment.