fix: remove duplicate winsorize_outliers definition - #3301
Open
0xtirth wants to merge 1 commit into
Open
Conversation
The second definition (lines 1381-1462) silently shadowed the first
(line 513) at import time. Kept V1 because existing tests require its
behavior: error message format ('lower must be less than upper'),
raising ValueError on non-numeric subset columns, and returning the
original frame identity when no numeric columns exist.
V2 also contained a docstring syntax error ('95th' parsed as invalid
decimal literal) that prevented module compilation.
Deleted 84 lines, no additions.
|
@0xtirth is attempting to deploy a commit to the xtylishanish-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second definition (lines 1381-1462) silently shadowed the first (line 513) at import time. Kept V1 because existing tests require its behavior: error message format ('lower must be less than upper'), raising ValueError on non-numeric subset columns, and returning the original frame identity when no numeric columns exist.
V2 also contained a docstring syntax error ('95th' parsed as invalid decimal literal) that prevented module compilation.
Deleted 84 lines, no additions.
issue : #3298