seo: add policy and blog page descriptions - #64
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dongjiang1989
left a comment
dongjiang1989
left a comment
There was a problem hiding this comment.
Thanks @FenjuFu
Great feature.
Need add Changelog to CHANGELOG.md
|
@dongjiang1989 Thanks for the review. Added the SEO and URL-driven filtering changes to the |
|
Please fix CI fail. DCO setting |
dongjiang1989
left a comment
dongjiang1989
left a comment
There was a problem hiding this comment.
Need to check all added English and Chinese descriptions
| frontmatter={{ | ||
| title: '贡献者许可协议', | ||
| titleEn: 'Contributor License Agreement', | ||
| description: |
There was a problem hiding this comment.
Addressed on current head eb45e56. The CLA frontmatter includes descriptionEn, and MarkdownLayout now consumes both description and descriptionEn when emitting the meta description. I also merged current main without rewriting history and kept the newer Projects/Events implementation from #100. Astro check reports 114 files with 0 diagnostics, focused ESLint/Prettier pass, and the production build generated 71 pages successfully.
|
Thanks @dongjiang1989! Added the changelog entry under |
|
@FenjuFu Need fix DCO sign |
8570bb1 to
05dc87e
Compare
|
@FenjuFu need rebase and fix review commit |
Make filtered views of the projects and events pages crawlable and shareable by moving filter state into URL query parameters: - /projects: category/language filters are now server-rendered links (?category=...&language=...) filtered on the server, replacing the client-side JS show/hide script; add an empty-state with a clear link - /events: switch to server rendering with ?type=... filter links, replacing the client-side filter script; event status (upcoming/ ongoing/past) is now computed at request time instead of being frozen at build time Canonical URLs already strip query strings, so filtered views canonicalize to the base list page and add no duplicate content. Also add unique meta descriptions to pages that previously fell back to the site-wide default: projects, events, adopters, landscape, contribute, CLA, values, security and the blog list/category/tag pages (MarkdownLayout now passes description through). Signed-off-by: FenjuFu <fufenjupku@gmail.com>
Signed-off-by: FenjuFu <fufenjupku@gmail.com>
05dc87e to
9cf373b
Compare
|
@dongjiang1989 Done — rebased onto latest |
Signed-off-by: FenjuFu <92919259+FenjuFu@users.noreply.github.com>
Signed-off-by: FenjuFu <92919259+FenjuFu@users.noreply.github.com>
FenjuFu
changed the title
2 participants
Summary
Current main already contains the redesigned Projects and Events directories from #100, including URL-synchronized filters and page-specific descriptions. This PR now preserves that newer implementation and narrows its remaining diff to SEO metadata that main still lacks:
The obsolete Projects, Events, Adopters, Contribute, blog index/category, and deleted Landscape implementations from the old branch were not carried over.
Review follow-up
The requested descriptionEn field is present on the CLA page. MarkdownLayout now also consumes it, combining description and descriptionEn in the emitted meta description.
Validation
The full npm run check reaches ESLint but is blocked on Windows by an unrelated parser/CRLF error in the unchanged main file src/components/common/Image.astro. The changed files pass focused ESLint.