Skip to content

Delete trailing new line character from pasted text #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nullnull wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Delete trailing new line character from pasted text #140

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9e062b
Delete trailing new line character from pasted text
nullnull Jul 16, 2021
acc08b9
Allow string verticalSeparator
nullnull Aug 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/matrix.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,10 @@ export function split<T>(
csv: string,
transform: (value: string) => T,
horizontalSeparator = "\t",
verticalSeparator: string | RegExp = /\r\n|\n|\r/
verticalSeparator = /\r\n|\n|\r/

@iddan iddan Jul 16, 2021

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not remove the ability to accept a string here

): Matrix<T> {
return csv
.replace(new RegExp('(' + verticalSeparator.source + ')$'), '') // delete trailing new line character

@iddan iddan Jul 16, 2021

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please support getting a string here

.split(verticalSeparator)
.map((row) => row.split(horizontalSeparator).map(transform));
}
Expand Down