fix: select correct columns when pulling attestations from db#279
Conversation
Coverage Report
File CoverageNo changed files found. |
Fixes a bug where the schema_uid was not selected correctly, which resulted in errors when fetching eas_schema using graphql as it's non-nullable.
2698e5d to
0975e42
Compare
That would simple mean it won't be supported in the V1 API, but only V2? |
|
To test, try to query an attestation with eas_schema on staging/prod graphql ui, vs when running locally using this branch, so this query: succeeds on http://localhost:4000/v1/graphql, but fails on https://staging-api.hypercerts.org/v1/graphql. @bitbeckers |
Yes, that could be reasonable I think? And then we should probably remove the args from the v1 API, so it doesn't seem like you'd be able to query by metadata? We haven't heard about it being broken yet, so my guess is that this functionality is not being used at the moment by api consumers? |
Fixes a bug where the schema_uid was not selected correctly, which resulted in errors when fetching eas_schema using graphql as it's non-nullable.
NOTE: Querying attestations by metadata is broken, as it was before. I spent some time trying to fix this but ran into issues. I think it would be more time-efficient to revisit that after #263 has been merged. That issue is related to nested inner joins, eg attestations joins claims joins metadata. Created #280 to track that.