Skip to content

Add flex_attn to diffllama - #35601

Merged
ArthurZucker merged 1 commit into
mainfrom
muellerzr-fix-failing-diffq
Jan 9, 2025
Merged

Add flex_attn to diffllama#35601
ArthurZucker merged 1 commit into
mainfrom
muellerzr-fix-failing-diffq

Conversation

@muellerzr

Copy link
Copy Markdown
Contributor

What does this PR do?

Should solve failing consistency checks

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ArthurZucker

@ArthurZucker ArthurZucker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ArthurZucker

Copy link
Copy Markdown
Collaborator

(Modeling file is not changed)

@ArthurZucker
ArthurZucker merged commit 8de7b1b into main Jan 9, 2025
@ArthurZucker
ArthurZucker deleted the muellerzr-fix-failing-diffq branch January 9, 2025 19:49
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Cyrilvallez

Copy link
Copy Markdown
Member

Actually I don't think DiffLlama supports flex, does it? 馃 It's still in the old format with classes

@ArthurZucker

Copy link
Copy Markdown
Collaborator

mmmm yeah looks like it but the pretrained mode in modular is a bit wrong in that case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants