[HfApi] Collections in collections#3120
Merged
hanouticelina merged 2 commits intomainfrom May 27, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3120 +/- ##
===========================================
- Coverage 76.33% 53.80% -22.53%
===========================================
Files 130 133 +3
Lines 12952 13286 +334
===========================================
- Hits 9887 7149 -2738
- Misses 3065 6137 +3072 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
julien-c
approved these changes
May 26, 2025
|
Just ran my scripts, and it does work as expected with this PR. Thank you so, so much!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally reported by @xeophon in this gist, it wasn't possible to access the collection slug when a collection item was itself a collection, and this was flagged internally by @Vaibhavs10 in this Slack message.
This PR enables proper client-side handling of collections that include collections as items. When the item type is "collection", we now set
item_idto the collection’s slug, ensuring consistency with how other item types (model, dataset, space, paper) are handled.for reference, server-side PR here (private link).