Skip to content

Fix invalid URL for pull request comments update/delete#182

Merged
kohsuke merged 1 commit into
hub4j:masterfrom
henryju:master
Jul 17, 2015
Merged

Fix invalid URL for pull request comments update/delete#182
kohsuke merged 1 commit into
hub4j:masterfrom
henryju:master

Conversation

@henryju

@henryju henryju commented Apr 27, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@buildhive

buildhive commented Apr 27, 2015

Copy link
Copy Markdown

Kohsuke Kawaguchi » github-api #334 SUCCESS
This pull request looks good
(what's this?)

@KostyaSha

KostyaSha commented Apr 27, 2015

Copy link
Copy Markdown
Contributor

Some test case will be appreciated

@buildhive

buildhive commented Apr 27, 2015

Copy link
Copy Markdown

Kohsuke Kawaguchi » github-api #335 SUCCESS
This pull request looks good
(what's this?)

@buildhive

buildhive commented Apr 27, 2015

Copy link
Copy Markdown

Kohsuke Kawaguchi » github-api #336 SUCCESS
This pull request looks good
(what's this?)

@henryju

henryju commented Apr 27, 2015

Copy link
Copy Markdown
Contributor Author

I have added some integration tests and fixed regression from last commit in master.

@buildhive

buildhive commented Apr 27, 2015

Copy link
Copy Markdown

Kohsuke Kawaguchi » github-api #337 SUCCESS
This pull request looks good
(what's this?)

@henryju

henryju commented May 6, 2015

Copy link
Copy Markdown
Contributor Author

Any update about this? Thanks

@oleg-nenashev

oleg-nenashev commented May 15, 2015

Copy link
Copy Markdown
Collaborator

👍

@buildhive

buildhive commented May 22, 2015

Copy link
Copy Markdown

Kohsuke Kawaguchi » github-api #344 SUCCESS
This pull request looks good
(what's this?)

@buildhive

buildhive commented May 22, 2015

Copy link
Copy Markdown

Kohsuke Kawaguchi » github-api #345 SUCCESS
This pull request looks good
(what's this?)

KostyaSha
KostyaSha reviewed May 22, 2015
View reviewed changes
Comment thread pom.xml Outdated

@KostyaSha KostyaSha May 22, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

@henryju henryju May 22, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I have updated my own fork without thinking about this open P/R. I'll fix that.

@buildhive

buildhive commented May 22, 2015

Copy link
Copy Markdown

Kohsuke Kawaguchi » github-api #346 SUCCESS
This pull request looks good
(what's this?)

@henryju

henryju commented Jun 16, 2015

Copy link
Copy Markdown
Contributor Author

Rebased on master for easier merge.

@buildhive

buildhive commented Jun 16, 2015

Copy link
Copy Markdown

Kohsuke Kawaguchi » github-api #356 SUCCESS
This pull request looks good
(what's this?)

kohsuke added a commit that referenced this pull request Jul 17, 2015
@kohsuke
Merge pull request #182 from henryju/master
c4113f1 
Fix invalid URL for pull request comments update/delete
@kohsuke kohsuke merged commit c4113f1 into hub4j:master Jul 17, 2015
@kohsuke

kohsuke commented Jul 17, 2015

Copy link
Copy Markdown
Collaborator

My apologies for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@henryju @buildhive @KostyaSha @oleg-nenashev @kohsuke