Fix windows 10 support - #42
Merged
Merged
Conversation
- Windows 10 native shell(#39) was rebinding to already bound ports. We now send a message from a socket client -> server -> client to ensure a host + port are actually open - Windows 10 bash shell falls back to using 0.0.0.0 as the only host we check in order to prevent throwing a syscall error as being tracked here: microsoft/WSL#468 fixes: #39 closes: #41 fixes: ember-cli/ember-cli#6338
This was referenced Oct 17, 2016
eriktrom
commented
Dec 8, 2016
|
|
||
| client.on('end', function() { | ||
| callback(null, options.port); | ||
| }); |
Member
Author
There was a problem hiding this comment.
future portfinder 2.0 partial code - includes fix for windows 10 native shell port rebinding and macbookpro with touchbar - and any other future issues that arise when listening on a port is not adequate - to use this portfinder needs to catch any OS errors that occur from trying to pipe data through a protected interface, such a bluetooth(and likely macbookpro touchbar) both which are interfaces returned by os.networkInterfaces()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now send a message from a socket client -> server -> client to ensure
a host + port are actually open
check in order to prevent throwing a syscall error as being tracked here:
os.networkInterfaces error in NodeJS / Yeoman microsoft/WSL#468
fixes: #39
closes: #41
fixes: ember-cli/ember-cli#6338