How to use -P in glslangValidatorArgs?

[yang-le]

Hi,

I'm trying to use -P in glslangValidatorArgs, but it doesn't seems to work.
"glsllint.glslangValidatorArgs": "-P\"#extension GL_GOOGLE_include_directive: enable\" -V"

An error reported as below

'string' : End of line in string
"'string literal' : required extension not requested: Possible extensions include:",
'' : compilation terminated

Can anyone help me with how to use -P? Thanks.

[hsimpson]

Do you have a minimalistic shader file where I can test this, then I will have a look into it and debug the extension. Probably there is a Problem with the string and how it will go into the arguments.

[yang-le]

Yes, please use the following shader source as test case.

#version 450
#include "preamble.glsl"

layout(location = 0) in vec3 Position;
layout(location = 1) in vec2 TexCoord;

layout(location = 0) out vec2 vTexCoord;

void main() {
    gl_Position = vec4(Position, 1.0);
    vTexCoord = TexCoord;
}

where preamble.glsl is

#define PI      3.1415926536
#define PI_HALF 1.5707963268

precision highp float;

[JuanDiegoMontoya]

Do you have a minimalistic shader file where I can test this, then I will have a look into it and debug the extension. Probably there is a Problem with the string and how it will go into the arguments.

FYI, I also get the error in this compute shader:

#version 450
void main() {}

My desire to use --P is also fueled by not wanting to write #extension GL_GOOGLE_include_directive: enable in every source file.

[hsimpson]

@yang-le and @JuanDiegoMontoya sorry for long time not answering, but I had many work to do and this project is only a free time project. :D

But today I had some time to figure out the problem and debug this. Indeed there is a problem with the glslangValidatorArgs property and I will create a fix to make this more robust. In my test code I could successfully validate the code from from you both.

I will provide an updated build of the extension in the next few days, for you to test. And if it works I will do the update to the marketplace.

[hsimpson]

@yang-le and @JuanDiegoMontoya I have created a pre-release for you to test the new feature to use glslangValidatorArgs as an array.

In settings.jon use it like:

// ...
"glsllint.glslangValidatorArgs": ["--P", "#extension GL_GOOGLE_include_directive: enable", "-V"]
// ...

See the pre release here:
https://github.com/hsimpson/vscode-glsllint/releases/tag/1.9.0

Please tell me if it works like you expected, then I will merge this into master and create a new release on the Marketplace