Support additional GLSL file extensions (e.g. .vs and .fs)

[alexgg-developer]

Hello,

I have just installed glsl lint and configured the path to the glsl validator but it does not seem to show any errors for the glsl code.

Info:

Version 1.30.1
GLSL Lint 0.0.4
OS: Windows 10.0.17134
Path used: C:\glslValidator\bin\glslangValidator.exe downloaded from : https://github.com/KhronosGroup/glslang/releases/tag/master-tot (release x64)

[alexgg-developer]

It was a problem related with the extension. I was using .vs and .fs and it only seems to work with .frag and .vert

[hsimpson]

Unfortunately the glslangValidator only supports a few extensions:
https://github.com/KhronosGroup/glslang/blob/master/StandAlone/StandAlone.cpp#L1290

I will ad them all and also add some error handling when the glslangValidator is called wrong

[liurui39660]

Hi, the support of glsl extension seems still problematic. I have some shader files like xxx.vert.glsl and xxx.frag.glsl, I can directly use glslangValidator in the command line, but the extension will throw errors when handling them.

The error pop-ups are

GLSL Lint: Wrong parameters when starting glslangValidator.
Arguments: -l --stdin -S stderr:

It's the same even I disabled glsllint.useIncludeDirOfFile and glsllint.linkShader. And

GLSL Lint: GLSL Lint: failed to map extension: '.glsl', you can add it to the extension setting 'glsllint.additionalStageAssociations'

I tried to add .frag.glsl and .glsl to glsllint.additionalStageAssociations, but no luck.

[hsimpson]

Is it possible to attach your shader files and your glsllint config object here? Then I can debug the problem.
If there are some secret algorithms in the shader files you could remove them ;-)

[liurui39660]

There's nothing secret, just the re-implementation of some common algorithms.

The config entries are

    "glsllint.linkShader": false,
    "glsllint.useIncludeDirOfFile": false,
    "glsllint.additionalStageAssociations": {
        ".frag.glsl": "frag",
        ".glsl": "frag"
    },

The shader file is as below, the validator should complain at line 45, where the function CastRay should have a return value. The original file name is SSGR.frag.glsl.

#version 460

in vec2 uv;
out vec4 posSSGR;
out vec3 normSSGR;
out vec4 colorSSGR;
out float blendSSGR;
uniform sampler2D posRTT, normRTT, colorRTT, reflRTT;
uniform mat4 p; // Projection matrix
uniform int width, height;

/// Convert view position to uv, z and w are kept
vec4 ToUV(vec3 posView) {
	vec4 posProjection = p * vec4(posView, 1);
	posProjection.xy = (posProjection.xy / posProjection.w + 1) / 2; // Range [0, 1]
	return posProjection;
}

vec3 BinarySearch(vec3 origin, vec3 direction, int limit) {
	float depthDelta;
	while (limit-- > 0) {
		depthDelta = origin.z - texture(posRTT, ToUV(origin).xy).z;
		origin += depthDelta > 0 ? direction : -direction;
		direction /= 2;
	}
	return origin;
}

// bool CastRay(vec3 origin, vec3 direction, out vec3 posHitView, out vec2 posHitUV) {
// 	const float sizeStep = 0.1;
// 	direction *= sizeStep; // Step size
// 	for (int i = 0; i < 350; i++) {
// 		origin += direction;
// 		float depthActual = texture(posRTT, ToUV(origin).xy).z;
// 		if (0 < depthActual - origin.z && depthActual - origin.z < 2 * sizeStep) {
// 			posHitView = BinarySearch(origin, direction, 20);
// 			posHitUV = ToUV(posHitView).xy;
// 			return clamp(posHitUV, 0, 1) == posHitUV;
// 		}
// 	}
// 	return false;
// }

// By default in view space
bool CastRay(vec3 origin, vec3 direction, out vec3 posHit, out vec2 posHitUV) {
	const int numMaxStep = 100;
	float numStep = origin.z + direction.z * numMaxStep < 0 ? -origin.z / direction.z : numMaxStep;
	vec3 target = origin + direction * numStep;

	vec4 originUV = ToUV(origin);
	vec4 targetUV = ToUV(target);

}

void main() {
	if (texture(reflRTT, uv).r == 0) discard;
	vec3 pos = texture(posRTT, uv).xyz;
	vec3 norm = texture(normRTT, uv).xyz;
	vec4 color = texture(colorRTT, uv);
	vec3 direction = normalize(reflect(normalize(pos), norm));
	vec3 posHitView;
	vec2 posHitUV;
	if (CastRay(pos, direction, posHitView, posHitUV)) {
		posSSGR = vec4(posHitView, 1);
		colorSSGR = texture(colorRTT, posHitUV);
		blendSSGR = clamp(distance(pos, posHitView) / 10, 0, 1);
	} else discard;
}

[hsimpson]

This problem is fixed with the latest release 1.0.0

[cptSwing]

Hi, the support of glsl extension seems still problematic. I have some shader files like xxx.vert.glsl and xxx.frag.glsl, I can directly use glslangValidator in the command line, but the extension will throw errors when handling them.

The error pop-ups are

GLSL Lint: Wrong parameters when starting glslangValidator.
Arguments: -l --stdin -S stderr:

It's the same even I disabled glsllint.useIncludeDirOfFile and glsllint.linkShader. And

GLSL Lint: GLSL Lint: failed to map extension: '.glsl', you can add it to the extension setting 'glsllint.additionalStageAssociations'

I tried to add .frag.glsl and .glsl to glsllint.additionalStageAssociations, but no luck.

This looks very similar to what I am experiencing. I attempted to add '.vertex.fx' and '.fragment.fx' like so:

"glsllint.additionalStageAssociations": {
	
		".fragment.fx": "frag",
		".vertex.fx": "vert"
	}

and get the following errors:

GLSL Lint: GLSL Lint: failed to map extension: '.fx', you can add it to the extension setting 'glsllint.additionalStageAssociations'

and

GLSL Lint: Wrong parameters when starting glslangValidator. Arguments: -l --stdin -S stderr:

running version 1.1.1