Harden sync, clipboard, and large-tab behavior - #3672
Draft
FreshSoftware4 wants to merge 15 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft consolidates the CopyQ bugfix pass described in the supplied sync-bug exports and rebases it onto the current upstream
masterwith normal ancestry.It:
Why
The original failure mode combined network-backed synchronized items, transient or permanent read failures, and code paths that treated missing data as an empty item. That could allow later command/removal paths to discard an item even though its synchronized payload had never been materialized successfully. Related clipboard and large-tab behavior amplified the reliability and responsiveness problems documented in the reproduction exports.
During review, two additional holes were found and fixed:
removestill ignored typed selection-copy failures, including remove-only commandsValidation
git diff --checkpassesQt6WidgetsConfig.cmake, Qt >= 6.2) is not installedThis is intentionally a draft while CI and maintainer review establish whether the broad bugfix pass should remain together or be split into smaller PRs.