Skip to content

Rename plugin.json to marketplace.json#528

Closed
BrayanWebDev wants to merge 1 commit into
heygen-com:mainfrom
BrayanWebDev:patch-1
Closed

Rename plugin.json to marketplace.json#528
BrayanWebDev wants to merge 1 commit into
heygen-com:mainfrom
BrayanWebDev:patch-1

Conversation

@BrayanWebDev
Copy link
Copy Markdown

It is needed in order to install Claude.

It is needed in order to install Claude.
Copy link
Copy Markdown
Collaborator

@miguel-heygen miguel-heygen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into the Claude Code plugin setup, but this rename is not correct as-is. .claude-plugin/plugin.json is the plugin manifest file for a plugin; .claude-plugin/marketplace.json is a different schema for a marketplace catalog.

I checked the current Claude Code docs and validated the renamed layout locally with Claude Code 2.1.121. The existing .claude-plugin/plugin.json validates successfully, but after renaming the same content to .claude-plugin/marketplace.json, claude plugin validate fails because marketplace manifests require owner and plugins, and the current plugin manifest fields like author, homepage, repository, and license are not valid at the marketplace root.

If the goal is to make HyperFrames installable through a Claude Code marketplace, please keep .claude-plugin/plugin.json and add a separate .claude-plugin/marketplace.json that contains a marketplace catalog, including a plugins entry pointing at the HyperFrames plugin source. A pure rename breaks the plugin manifest and does not create a valid marketplace.

@joweiser
Copy link
Copy Markdown
Contributor

joweiser commented May 8, 2026

@miguel-heygen Would you be okay if I create a pull request with the necessary marketplace.json file?

Copy link
Copy Markdown
Collaborator

@miguel-heygen Would you be okay if I create a pull request with the necessary marketplace.json file?

​it would be perfect for sure

miguel-heygen added a commit that referenced this pull request May 8, 2026
Added a Claude Code marketplace manifest as announced here #528 (comment)
Copy link
Copy Markdown
Collaborator

@vanceingalls vanceingalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review at e092243f — quick read.

Audited

  • .claude-plugin/marketplace.json (single file rename, no content change)
  • Miguel's prior REQUEST_CHANGES review (2026-04-28)

Miguel's prior review is correct

@miguel-heygen explained the structural issue clearly: .claude-plugin/plugin.json is the plugin manifest (this file's correct identity); .claude-plugin/marketplace.json is a different concept (a marketplace listing file). The rename swaps two semantically distinct files.

There are no new commits since Miguel's review on 2026-04-28 (15 days). The PR appears stalled — author either misunderstood Claude Code's plugin convention or hasn't seen Miguel's feedback.

Recommendation

Close this PR. The author's framing ("It is needed in order to install Claude.") suggests they hit a specific Claude Code install error that named marketplace.json, but the fix isn't to rename — it's likely to add a separate marketplace.json IF this repo wants to be installable from a custom marketplace, while keeping plugin.json as the plugin manifest.

If the author wants to add Claude marketplace support, the right shape is a NEW marketplace.json file alongside the existing plugin.json. That's a small PR that wouldn't have any of the "swap two semantically different files" risk this PR has.

Verdict

Verdict: REQUEST CHANGES
Reasoning: Rename swaps two semantically distinct Claude Code config files (plugin.json is the plugin manifest, marketplace.json is a marketplace listing — they are not interchangeable). Miguel flagged this 15 days ago; no commits since. External-contributor PR — recommend closing and asking the author to file a different PR if they want to add marketplace support.

— Vai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants