Skip to content

fix: make generated BPF toolchains analyzable on any CPU #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzbarsky merged 1 commit into from
Sep 5, 2026
Merged

fix: make generated BPF toolchains analyzable on any CPU #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions rs/toolchains/declare_rustc_toolchains.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,10 +223,12 @@ def declare_rustc_toolchains(
process_wrapper = "@rules_rust//util/process_wrapper",
rust_std = toolchain_rust_std,
**(rust_toolchain_kwargs | {
"linker": select({
"@platforms//cpu:bpfeb": bpf_linker_label,
"@platforms//cpu:bpfel": bpf_linker_label,
}),
# Both branches of the former select held this same label, and
# a select with no default cannot be analyzed for any other
# CPU -- which breaks `bazel cquery` over the generated
# package. BPF targets are already gated by the toolchain's
# target_settings.
"linker": bpf_linker_label,

@dzbarsky dzbarsky Sep 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, good idea, thank you!

})
)

Expand Down
Loading