[WIP] Allow annotating proc macros to live in the exec universe for feature resolution - #168
Open
dzbarsky wants to merge 11 commits into
Open
[WIP] Allow annotating proc macros to live in the exec universe for feature resolution#168dzbarsky wants to merge 11 commits into
dzbarsky wants to merge 11 commits into
Conversation
|
Got my agent to run some tests on #157 vs #168 here is the verdict :) Performance (448-core box, cold bazel clean, no disk cache)
|
Member
Author
|
Thanks for trying it! "exec features are seeded from target-world activations" sounds off to me, that might be a bug. Some of the other things in the table above also seem surprising to me; let me give this a spin on openAIs repo when I'm back at work next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.