Conversation
Member
|
I wonder if we can gate v2 behind a feature flag? I don't want to break other tree-house consumers to introduce support for ropey v2 if we can avoid it. If not, we could make use a new minor to add ropey v2 support and backport any fixes we make to the previous minor, for better compatibility. cc @hadronized we will eventually want to migrate tree-house (as well as all of Helix) towards ropey v2 and then cessen will release ropey v2, FYI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires helix-editor/regex-cursor#6