Skip to content

allow for higher F keys to be used - #7672

Merged
archseer merged 1 commit into
helix-editor:masterfrom
christianholman:more-function-keys
Jul 19, 2023
Merged

allow for higher F keys to be used#7672
archseer merged 1 commit into
helix-editor:masterfrom
christianholman:more-function-keys

Conversation

@christianholman

Copy link
Copy Markdown
Contributor

As mentioned in #7669, windows allows for higher function keys than F12.
Additionally, custom keyboard firmwares like ZMK support up to F24 https://zmk.dev/docs/codes/keyboard-keypad#f-keys

@pascalkuthe pascalkuthe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test this since I don't use these keys but this seems reasonable to me. I think in the past crossterm didn't support these keys (its in the changelog as new) so that's probably why it was forbidden in the past

@pascalkuthe pascalkuthe added E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer. A-keymap Area: Keymap and keybindings labels Jul 18, 2023
@archseer
archseer merged commit 579f68b into helix-editor:master Jul 19, 2023
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-keymap Area: Keymap and keybindings E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants