Add typst language and lsp - #7474
Conversation
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
|
This would be useful |
|
I am not big on pull request (never done it). But, is it possible to change the grammar to my own on the pull request? |
|
@uben0 either ask @AlexanderBrevig to use your grammar, or open a PR. You can get this PR's diff here and apply it to your helix clone with |
|
Just fyi @uben0 to be able to add it to helix you'll need to check in these files https://github.com/uben0/tree-sitter-typst/blob/master/.gitignore#L5-L8 (all the ones generated by the cli) I have been using your grammar for a couple days and it does seem the most complete so I agree with using it |
|
I will update this PR |
Will you let me know @uben0 when the files are in the repo? |
|
Good morning
I added the generated source. If I did something wrong, tell me.
And the highlight and injection queries files are in the queries directory.
Thanks a lot.
------- Original Message -------
…On Monday, September 18th, 2023 at 10:03 AM, Alexander Brevig ***@***.***> wrote:
> Just fyi ***@***.***(https://github.com/uben0) to be able to add it to helix you'll need to check in these files https://github.com/uben0/tree-sitter-typst/blob/master/.gitignore#L5-L8 (all the ones generated by the cli) I have been using your grammar for a couple days and it does seem the most complete so I agree with using it
Will you let me know ***@***.***(https://github.com/uben0) when the files are in the repo?
Nice work BTW!
—
Reply to this email directly, [view it on GitHub](#7474 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AHG5WSURZNQYAWD32ZT5Z3TX2756VANCNFSM6AAAAAAZXA6FYU).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Updated TS grammar to https://github.com/uben0/tree-sitter-typst Thank you @uben0! |
|
Hi,
There was an typo in Cargo.toml, where the grammar had a different name. It was causing a bug when executing cargo test. I fixed it. If you can update the revision number.
------- Original Message -------
…On Monday, September 18th, 2023 at 10:03 AM, Alexander Brevig ***@***.***> wrote:
> Just fyi ***@***.***(https://github.com/uben0) to be able to add it to helix you'll need to check in these files https://github.com/uben0/tree-sitter-typst/blob/master/.gitignore#L5-L8 (all the ones generated by the cli) I have been using your grammar for a couple days and it does seem the most complete so I agree with using it
Will you let me know ***@***.***(https://github.com/uben0) when the files are in the repo?
Nice work BTW!
—
Reply to this email directly, [view it on GitHub](#7474 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AHG5WSURZNQYAWD32ZT5Z3TX2756VANCNFSM6AAAAAAZXA6FYU).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
realeinherjar
left a comment
There was a problem hiding this comment.
LGTM, just get the @the-mikedavis changes in
|
Too bad that this could not be in 23.11 :( |
I try it again in the latest hx. |
Agreed, given the five months between the previous release and the latest one. |
|
@AlexanderBrevig Maybe it is worth it to update the tree sitter to the newest version to support typst 0.9 |
|
I'll work on it |
|
I have been checking the change log for Typst 0.9 and it seams like the only change related to syntax is the addition of builtin |
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

Will add to the wiki when/if merged.
Closes #6688