Skip to content

Add typst language and lsp - #7474

Merged
pascalkuthe merged 14 commits into
helix-editor:masterfrom
AlexanderBrevig:feat/add-typst
Oct 26, 2023
Merged

Add typst language and lsp#7474
pascalkuthe merged 14 commits into
helix-editor:masterfrom
AlexanderBrevig:feat/add-typst

Conversation

@AlexanderBrevig

@AlexanderBrevig AlexanderBrevig commented Jun 28, 2023

Copy link
Copy Markdown
Contributor

image

Will add to the wiki when/if merged.

Closes #6688

@AlexanderBrevig

Copy link
Copy Markdown
Contributor Author

https://typst.app/docs/

Comment thread languages.toml
Comment thread languages.toml Outdated
@kirawi kirawi added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Jun 30, 2023
Comment thread runtime/queries/typst/highlights.scm Outdated
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
the-mikedavis
the-mikedavis previously approved these changes Jul 9, 2023
@Phant80m

Phant80m commented Aug 8, 2023

Copy link
Copy Markdown

This would be useful

@erasin

erasin commented Aug 20, 2023

Copy link
Copy Markdown
Contributor

#6688

Comment thread languages.toml Outdated
@uben0

uben0 commented Sep 17, 2023

Copy link
Copy Markdown

I am not big on pull request (never done it). But, is it possible to change the grammar to my own on the pull request?
I wrote and maintain a grammar which is complete at https://github.com/uben0/tree-sitter-typst
Or should I create another pull request?

@fufexan

fufexan commented Sep 17, 2023

Copy link
Copy Markdown

@uben0 either ask @AlexanderBrevig to use your grammar, or open a PR.

You can get this PR's diff here and apply it to your helix clone with git apply -p1 < typst.patch. Then you can modify the grammar to point to your repo.

@gabydd

gabydd commented Sep 17, 2023

Copy link
Copy Markdown
Member

Just fyi @uben0 to be able to add it to helix you'll need to check in these files https://github.com/uben0/tree-sitter-typst/blob/master/.gitignore#L5-L8 (all the ones generated by the cli) I have been using your grammar for a couple days and it does seem the most complete so I agree with using it

@AlexanderBrevig

Copy link
Copy Markdown
Contributor Author

I will update this PR

@AlexanderBrevig

Copy link
Copy Markdown
Contributor Author

Just fyi @uben0 to be able to add it to helix you'll need to check in these files https://github.com/uben0/tree-sitter-typst/blob/master/.gitignore#L5-L8 (all the ones generated by the cli) I have been using your grammar for a couple days and it does seem the most complete so I agree with using it

Will you let me know @uben0 when the files are in the repo?
Nice work BTW!

@uben0

uben0 commented Sep 18, 2023 via email

Copy link
Copy Markdown

@AlexanderBrevig

Copy link
Copy Markdown
Contributor Author

Updated TS grammar to https://github.com/uben0/tree-sitter-typst

Thank you @uben0!

image

@uben0

uben0 commented Sep 18, 2023 via email

Copy link
Copy Markdown

Comment thread runtime/queries/typst/highlights.scm Outdated

@realeinherjar realeinherjar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just get the @the-mikedavis changes in

the-mikedavis
the-mikedavis previously approved these changes Sep 27, 2023
Comment thread runtime/queries/typst/highlights.scm Outdated
@realeinherjar

Copy link
Copy Markdown

Too bad that this could not be in 23.11 :(

@lydiandy

lydiandy commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

Too bad that this could not be in 23.11 :(

I try it again in the latest hx.
it is ok.

@pascalkuthe
pascalkuthe merged commit 2906660 into helix-editor:master Oct 26, 2023
@cinerea0

Copy link
Copy Markdown
Contributor

Too bad that this could not be in 23.11 :(

Agreed, given the five months between the previous release and the latest one.

@Idobenhamo

Copy link
Copy Markdown
Contributor

@AlexanderBrevig Maybe it is worth it to update the tree sitter to the newest version to support typst 0.9

@uben0

uben0 commented Nov 1, 2023

Copy link
Copy Markdown

I'll work on it

@uben0

uben0 commented Nov 3, 2023

Copy link
Copy Markdown

I have been checking the change log for Typst 0.9 and it seams like the only change related to syntax is the addition of builtin quote function. I can't find any other change related to syntax. Can anyone double check this?

danillos pushed a commit to danillos/helix that referenced this pull request Nov 21, 2023
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
@AlexanderBrevig
AlexanderBrevig deleted the feat/add-typst branch June 30, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is there any plan to support typst?