Skip to content

Update languages.toml for Nickel - #7059

Merged
the-mikedavis merged 4 commits into
helix-editor:masterfrom
vkleen:nickel-update
May 26, 2023
Merged

Update languages.toml for Nickel#7059
the-mikedavis merged 4 commits into
helix-editor:masterfrom
vkleen:nickel-update

Conversation

@vkleen

@vkleen vkleen commented May 17, 2023

Copy link
Copy Markdown
Contributor

Update the revision of tree-sitter-nickel and copy over the highlighting queries. Also, adjust the auto-pairs configuration, since ' isn't a paired delimiter in Nickel.

ErinvanderVeen
ErinvanderVeen previously approved these changes May 17, 2023
Comment thread runtime/queries/nickel/highlights.scm
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-language-support Area: Support for programming/text languages labels May 18, 2023
the-mikedavis
the-mikedavis previously approved these changes May 19, 2023

@the-mikedavis the-mikedavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 19, 2023
@pascalkuthe

pascalkuthe commented May 19, 2023

Copy link
Copy Markdown
Member

Seems like CI is failing with some indentation query related error. Seems like those also need to be updated before we can merge

@the-mikedavis

Copy link
Copy Markdown
Member

@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from a maintainer. labels May 20, 2023
@vkleen

vkleen commented May 20, 2023

Copy link
Copy Markdown
Contributor Author

I'll take care of that later today, thanks for diagnosing!

@pascalkuthe pascalkuthe added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 20, 2023
@the-mikedavis
the-mikedavis merged commit 0c21c22 into helix-editor:master May 26, 2023
aotarola pushed a commit to aotarola/helix that referenced this pull request May 28, 2023
aotarola pushed a commit to aotarola/helix that referenced this pull request May 28, 2023
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants