Raise MSRV to 1.65 - #6185
Merged
Merged
Conversation
This fixes breakage when installing `helix` due to an incorrect usage of `as_ref()` when interacting with `bstr` in the `gitoxide` codebase. However, this upgrade also requires a higher rustc version, as `gitoxide` recently updated its `windows` crate version.
Co-authored-by: Ivan Tham <pickfire@riseup.net>
pascalkuthe
added
E-easy
the-mikedavis
approved these changes
Mar 5, 2023
Member
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates MSRV to 1.65 per our policy.
Ubuntu has finally followed their own policy and updated rustc to 1.65 so this should now be uncontroversial and not cause any problems.
This PR includes #6065 (with permission from @Byron) to update gix and the usual update of the CI,
rust-toolchain.tomland resolving of MSRV related TODOs (clippy lints were resolved in #5892)Note that the large diff is caused by
Cargo.lockchanges mostly from renaming all thegitoxidesubcrates fromgit-..togix-..and gitoxide dropping dependencies (caused by reviews from the cargo people, as gitoxide is now used incargo)