Fix: decode lsp url for workspace_diagnostics_picker - #6016
Merged
Conversation
Member
|
This seems unnecessary since the |
Member
|
Yup: "Return the path for this URL, as a percent-encoded ASCII string." |
erasin
force-pushed
the
diagnostic_workspace_url
branch
from
February 16, 2023 14:10
dca658a to
125b34f
Compare
erasin
force-pushed
the
diagnostic_workspace_url
branch
from
February 16, 2023 14:12
125b34f to
45d9121
Compare
Contributor
Author
|
Remove thanks for review. |
pascalkuthe
approved these changes
Feb 16, 2023
pascalkuthe
left a comment
pascalkuthe
left a comment
Member
There was a problem hiding this comment.
This LGTM now 👍 We simply used the wrong function here. We already use to_file_path everywhere else.
pascalkuthe
added
C-bug
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I used CJK characters as the path, the lsp returned the encoded content, and the correct path would be displayed only after decoding.