feat: add pem language - #5797
Merged
Merged
Conversation
mtoohey31
marked this pull request as draft
February 3, 2023 04:17
Contributor
Author
|
Just realized the grammar only supports one block per file. I'll update this and mark it as ready once I've fixed that. |
mtoohey31
marked this pull request as ready for review
February 4, 2023 03:51
Contributor
Author
|
Alright, that's been fixed, and I've rebased things and resolved the merge conflicts. Here's a screenshot with multiple blocks:
|
the-mikedavis
added
S-waiting-on-review
the-mikedavis
approved these changes
Feb 7, 2023
the-mikedavis
left a comment
the-mikedavis
left a comment
Member
There was a problem hiding this comment.
It's a pretty small parser (I see tens of KB on Linux) so I think it's ok to add 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request adds support for PEM files. I'm not sure whether this sort of less commonly editied filetype is something we'd like to support out of the box, but I've been working with PEM files pretty frequently recently, so I figured I'd suggest adding support. Here's a screenshot with the nord theme: