Add Darcula Solid theme - #5778
Merged
Merged
Conversation
jesusmgg
marked this pull request as ready for review
February 2, 2023 06:53
the-mikedavis
added
A-theme
Member
There was a problem hiding this comment.
Does this overlap with Darcula much (changing the palette and a few scopes)? If so it would be good to re-use most of that theme with theme inheritance: https://docs.helix-editor.com/master/themes.html#inheritance
See the monokai_aqua theme for an example
Contributor
Author
Makes sense, I'll look into it and update. |
Contributor
Author
|
Now inheriting the original |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the original Darcula, with darker and more contrasting colors.
Original repository: https://github.com/jesusmgg/darcula-solid-helix