Skip to content

Add markup.strikethrough theme keys - #5619

Merged
the-mikedavis merged 1 commit into
helix-editor:masterfrom
CptPotato:markup-strikethrough
Jan 21, 2023
Merged

Add markup.strikethrough theme keys#5619
the-mikedavis merged 1 commit into
helix-editor:masterfrom
CptPotato:markup-strikethrough

Conversation

@CptPotato

@CptPotato CptPotato commented Jan 21, 2023

Copy link
Copy Markdown
Contributor

This PR adds markup.strikethrough to all themes that specify markup.italic/markup.bold.

I tried to adhere to the themes where possible ("/' quotes, key order and comments).

closes #5595

Comment thread runtime/themes/meliora.toml
@CptPotato

CptPotato commented Jan 21, 2023

Copy link
Copy Markdown
Contributor Author

Can anyone give this a spin?

The crossed_out modifier first worked when I tried it, but for whatever reason it doesn't on my machine. I might have messed up my helix grammars, as multiple markdown styles (bold, italic, inline code, etc.) are missing.

Edit: nevermind, looks like I was missing the markdown_inline grammar.

@CptPotato
CptPotato force-pushed the markup-strikethrough branch from 27f7091 to 0ed8119 Compare January 21, 2023 09:28
@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Jan 21, 2023
@CptPotato
CptPotato force-pushed the markup-strikethrough branch from 0ed8119 to 20702a7 Compare January 21, 2023 21:51
@the-mikedavis
the-mikedavis merged commit f103d22 into helix-editor:master Jan 21, 2023
kirawi pushed a commit to kirawi/helix that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specify markup.strikethrough in themes

3 participants