Skip to content

Sonokai - #3595

Merged
the-mikedavis merged 2 commits into
helix-editor:masterfrom
p4ymak:sonokai
Aug 29, 2022
Merged

Sonokai#3595
the-mikedavis merged 2 commits into
helix-editor:masterfrom
p4ymak:sonokai

Conversation

@p4ymak

@p4ymak p4ymak commented Aug 29, 2022

Copy link
Copy Markdown
Contributor

Added Sublime Text theme Sonokai.

@AlexanderBrevig

AlexanderBrevig commented Aug 29, 2022

Copy link
Copy Markdown
Contributor

Hi! Looking good!
Can you please add

"ui.cursorline.primary" = { bg = "something" }

To the theme so that #3234 lints OK and that I can see the cursorline I expect to see when using the theme?

Of course, replace something to whatever you think is nice (I liked bg1 and bg2).

image
Like this for instance:
image

@AlexanderBrevig AlexanderBrevig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add key; "ui.cursorline.primary" ref comment.

@AlexanderBrevig AlexanderBrevig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@p4ymak

p4ymak commented Aug 29, 2022

Copy link
Copy Markdown
Contributor Author

added "ui.cursorline.primary"

@the-mikedavis
the-mikedavis merged commit ab67788 into helix-editor:master Aug 29, 2022
@the-mikedavis

Copy link
Copy Markdown
Member

Could you add a screenshot of this to the themes wiki? https://github.com/helix-editor/helix/wiki/Themes

@p4ymak

p4ymak commented Aug 29, 2022

Copy link
Copy Markdown
Contributor Author

Could you add a screenshot of this to the themes wiki? https://github.com/helix-editor/helix/wiki/Themes

Done!

thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
Co-authored-by: Roman Chumak <p4ymak@yandex.ru>
jdrst pushed a commit to jdrst/helix that referenced this pull request Sep 13, 2022
Co-authored-by: Roman Chumak <p4ymak@yandex.ru>
herkhinah pushed a commit to herkhinah/helix that referenced this pull request Dec 11, 2022
Co-authored-by: Roman Chumak <p4ymak@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants