Themes update

[AlexanderBrevig]

This is a collection of changes made to force themes to handle in a predictable way. It also enforces a response to enabling features (like cursorline) so users who want these features will still see them even if they change themes.

I've tried my best to stick to the spirit of the theme, but some themes relied so much on terminal colors that I just had to guess and base some assumptions from other editors with similar themes.

Status from original authors (in terms of approvals)

• snazzy @nrdxp
• pop-dark @workingj
• penumbra @vlmutolo
• noctis_bordo @jharrilim
• ingrid @intarga
• flatwhite @AlexanderBrevig
• doom_acario_dark @Rinnray
• dark_plus @kirawi
• boo_berry @bootradev
• bogster @vv9k
• everforest @CptPotato @WindSoilder
• acme @two-six
• serika @VuiMuich
• nord @raygervais @two-six
• dracula @samsartor
• gruvbox @crodjer @jbaa
• autumn @getreu
• ayu @enkodr
• rose_pine @raygervais @chunghha @atahabaki
• monokai @WindSoilder
• solarized @kirawi @cossonleo
• spacebones @atog

[AlexanderBrevig]

It's done @archseer
This PR contains all changes. I opted for a task list for keeping track of author feedback. There's really no intended aesthetic changes/choices made here though.

Let me know if you'd want side by side screenshots for any of them :)

[WindSoilder]

Thank you! I'm ok with monokai and everforest changes

[vlmutolo]

The penumbra changes result in the command help text being unreadable on my machine.

What was the original issue the linter found with penumbra+? Maybe I can help resolve it.

[AlexanderBrevig]

The penumbra changes result in the command help text being unreadable on my machine.

What was the original issue the linter found with penumbra+? Maybe I can help resolve it.

Looking at it here it has sky for bg. That's wrong isn't it? Don't know what's happened, I'll fix it to shade later tonight. Thanks!

Penumbra only set fg for some fields that expects a bg. Most important were ui.background and ui.help and it seems somehow that a bug slipped through the cracks on this one where I used the original value (which in reality had no impact on the rendered theme and defaulted to terminal settings)

[AlexanderBrevig]

Penumbra looks better now?

[nrdxp]

Snazzy looks good 👍

[AlexanderBrevig]

Rebased.

[pickfire]

Looks good to me. I guess we don't really have to wait for all authors to get come back and tick this, those that wanted some changes can just submit a pull request separately later, but it's good to still notify them.

[kirawi]

I'm not the author of the solarized themes by the way.