Improve dart indent - #3419
Merged
Merged
Conversation
the-mikedavis
self-requested a review
August 14, 2022 15:43
the-mikedavis
left a comment
the-mikedavis
left a comment
Member
There was a problem hiding this comment.
This is looking good. I think the "this one is not actually used" commented out nodes can be removed, right?
Contributor
Author
|
Yes, they can be removed (I did in the next commit). They corresponds to declaration in the syntax with braces, but are actually not contained by a node in the program syntax. For example, here https://github.com/seb-bl/tree-sitter-dart/blob/455556f37ca9f208bdbeb76fffb4e3fd331ebf08/grammar.js#L726 |
the-mikedavis
approved these changes
Aug 24, 2022
Member
|
Thank you! |
AlexanderBrevig
pushed a commit
to AlexanderBrevig/helix
that referenced
this pull request
Aug 29, 2022
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
jdrst
pushed a commit
to jdrst/helix
that referenced
this pull request
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the indentation for dart. It is based on a more recent version of the grammar, so it updates it in addition to changing
runtime/queries/dart/indents.scm