highlight closure pipes as brackets - #3397
Merged
Merged
Conversation
the-mikedavis
approved these changes
Aug 11, 2022
the-mikedavis
left a comment
the-mikedavis
left a comment
Member
There was a problem hiding this comment.
Good call, these should be punctuation.bracket 👍
AlexanderBrevig
pushed a commit
to AlexanderBrevig/helix
that referenced
this pull request
Aug 29, 2022
Co-authored-by: Vince Mutolo <vince@mutolo.org>
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Vince Mutolo <vince@mutolo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently closure pipes highlight as operators, even though semantically they should be brackets. This PR adds an explicit highlight for pipes within the
closure_parametersscope.