Fix php hightlight - #3317
Merged
Merged
Conversation
namespace fucntion
archseer
reviewed
Aug 4, 2022
Comment on lines
+15
to
+17
| (subscript_expression | ||
| (variable_name(name) @constant.builtin) | ||
| ) |
Member
There was a problem hiding this comment.
for code like
$array = ['One', 'Two', 'Three'];
echo $array[0]; // => "One"This now highlights arrays in L2 as constant.builtin but I think the variable capture from before was more accurate
Contributor
Author
There was a problem hiding this comment.
(subscript_expression
(variable_name(name) @constant.builtin
(#match? @constant.builtin "^_?[A-Z][A-Z\\d_]+$")))
it‘s seem ok
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
namespace


fucntion