Skip to content

Add Doom's Acario dark theme. - #3308

Merged
the-mikedavis merged 2 commits into
masterfrom
unknown repository
Aug 6, 2022
Merged

Add Doom's Acario dark theme.#3308
the-mikedavis merged 2 commits into
masterfrom
unknown repository

Conversation

@Pupyrinth

Copy link
Copy Markdown

This theme is ported from acario themes from Doom Emacs.

I've however only focused on the dark one as that's the one I'm using.

This theme is ported from [acario themes](https://github.com/doomemacs/themes/blob/master/themes/doom-acario-dark-theme.el) from Doom Emacs.

I've however only focused on the dark one as that's the one I'm using.
@the-mikedavis
the-mikedavis self-requested a review August 2, 2022 21:26
@the-mikedavis the-mikedavis added the A-theme Area: Theme and appearence related label Aug 2, 2022
@AlexanderBrevig

AlexanderBrevig commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

Nice!

I ran it through #3234 and got

"acario":[
	"ui.cursorline"
]

I think ui.cursorline should be defined.

It may be argued that ui.statusline.normal|insert|select should be sepecified as well, in order to adhere to the editor.color-modes setting?

Added `ui.cursorline`, `ui.statusline.normal/insert/select`
@Pupyrinth

Copy link
Copy Markdown
Author

I didn't see anything different when I defined those, but I added them!
Statusline is the same color either way.

@AlexanderBrevig

Copy link
Copy Markdown
Contributor

I didn't see anything different when I defined those, but I added them! Statusline is the same color either way.

Both of them are behind setting. You must enable color-modes and cursorline (I just realized this may not be available if you use an official release. Thanks for adding anyway)

@the-mikedavis the-mikedavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thanks! 🎨

Could you add a screenshot to the themes wiki? https://github.com/helix-editor/helix/wiki/Themes

@the-mikedavis
the-mikedavis merged commit 7176c84 into helix-editor:master Aug 6, 2022
@Pupyrinth
Pupyrinth deleted the patch-1 branch August 6, 2022 20:50
@Pupyrinth

Copy link
Copy Markdown
Author

Looks nice, thanks! art

Could you add a screenshot to the themes wiki? https://github.com/helix-editor/helix/wiki/Themes

Will do!

thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-theme Area: Theme and appearence related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants