add language idris - #2971
Merged
Merged
Conversation
archseer
approved these changes
Jul 5, 2022
archseer
left a comment
archseer
left a comment
Member
There was a problem hiding this comment.
Thanks! I think that's fine, we can always rename it in the future if needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the Idris2 language. No grammar is included yet because I don't believe there is one (but I'm happy to be proven wrong if someone is able to find one). The only repo I could find was this one, but it's incomplete.
I have tested the language server and it works without issues.
The only thing I was unsure about is whether the filetype should be called
idrisoridris2, since there are breaking changes between the two languages. I lean towardsidris, because:.idrextension, so we couldn't really support both even if we wanted to since there's no simple way to distinguish between the languages