adds --vsplit and --hsplit arguments - #2773
Conversation
|
What happens if the user opens so many buffers with splits that it can't fit in the editor? Is there a limit? Should there be? |
|
There's a practical limit that will lead to a panic with |
|
That scenario is probably better resolved in a separate PR then. |
|
From what I have been able to gather, the limit of splits you can have does in With a terminal of size 2576x1426, the max number of splits the editor can open If one opens more buffers than the editor can "hold", the program panics and This line is inside a function called |
…ut>, and some cleanup
|
Little detail, but instead of defaulting to |
the-mikedavis
left a comment
There was a problem hiding this comment.
This looks great 👍
Thanks for updating the completion too 😀
adds the
--vsplitand--hsplitfeatures as proposed by #2709.When multiple files are opened in the editor via the command line, i.e.
hx test1.txt test2.txt, the user can use these new arguments to tell the program how these files should be presented.hx test1.txt test2.txt --vsplitopens both files side-by-side, whereashx test1.txt test2.txt --hsplitopens them on top of each other.I also added the new arguments to the completion scripts (hopefully correctly).
If the user passes in both of these options,
--vsplitis used as a default.