fix Markdown list highlighting

[ChrHorn]

This should fix #1597

I did it according to the current docs. Question is, should we

1. keep the 2 different styles for ordered/unordered
2. add markup for list text itself

[the-mikedavis]

What would you think about markup.list.ordered/markup.list.unordered similar to the HTML phrases for these? I don't mind numbered and unnumbered though.

[the-mikedavis]

for the questions:

1. I like the distinction between ordered and unordered. A theme can define just markup.list as a fallback so it doesn't have to theme them differently if it doesn't want.
2. I don't mind not theming the item text. I don't really see a scenario where it would be useful. But I probably wouldn't argue against it.

[ChrHorn]

What would you think about markup.list.ordered/markup.list.unordered similar to the HTML phrases for these? I don't mind numbered and unnumbered though.

Yes, that would be a good idea. The spec uses ordered list and bullet list but I would prefer unordered.

[ChrHorn]

Reanaming should not cause any issues. There was only one existing theme that used these fields. Didn't see it on external repos either.

[archseer]

Why the rename though? I tried keeping the same scopes as textmate / sublime themes https://www.sublimetext.com/docs/scope_naming.html#markup

[ChrHorn]

Makes sense, consistency with that spec is more important. Have reverted the renaming. Should be ready to merge.