add languages r and rmarkdown - #1998
Merged
Merged
Conversation
archseer
requested changes
Apr 7, 2022
Member
Let's just leave it for now Does the user need to install the package manually? |
Contributor
Author
Yep, the command is: R -e 'install.packages("languageserver")'Is there somewhere that should be documented? |
Contributor
No, if the user use the language chances are they will know, unless it requires special setup then maybe you might want to note it. |
Contributor
Author
|
Ok, sounds good. That's all the setup that's required. |
pickfire
reviewed
Apr 7, 2022
Member
|
For the installation docs, there's a new wiki for that here if you wouldn't mind adding in a section for R. |
Contributor
Author
Done!
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few notes:
{r}code blocks but should only be enabled inrmd/Rmdfiles.And two questions:
Ris an interpreted language, but I've never seen someone use a shebang in an R file. Any opinion on whether I should leave it or remove it?lang-support.mdfile appears to use the name of the language server command for the default language server column. However, the name of the command for the language server in use here (this one, it's the only one I'm aware of) is just theRinterpreter itself, and the arguments instruct it to invoke thelanguageserverpackage. Do we want to add in a workaround for this kind of situation so we can name thelanguageserverpackage specifically, or should we just leave it?