Resolve conflicts between prompt/picker bindings - #1792
Merged
Conversation
Currently, the picker's re-using a few bindings which are also present in the prompt. This causes some editing behaviours to not function on the picker. **Ctrl + k** and **Ctrl + j** This should kill till the end of the line on prompt, but is overridden by the picker for scrolling. Since there are redundancies (`Ctrl + p`, `Ctrl + n`), we can remove it from picker. **Ctrl + f** and **Ctrl + b** This are used by the prompt for back/forward movement. We could modify it to be Ctrl + d and Ctrl + u, to match the `vim` behaviour.
crodjer
force-pushed
the
picker-prompt-conflicts
branch
from
March 11, 2022 11:23
dca284d to
e07d269
Compare
archseer
approved these changes
Mar 31, 2022
archseer
left a comment
archseer
left a comment
Member
There was a problem hiding this comment.
Thanks! I don't know if I use ctrl-k/-j or -p/-n on the picker but I guess we'll see, I might need to retrain my muscle memory :D
Contributor
|
The Cc: @archseer |
Contributor
|
Ah, I missed this PR -- I opened the original issue to add |
This was referenced Dec 8, 2022
Closed
littleblack111
added a commit
to littleblack111/helix
that referenced
this pull request
Sep 10, 2025
littleblack111
added a commit
to littleblack111/helix
that referenced
this pull request
Sep 12, 2025
littleblack111
added a commit
to littleblack111/helix
that referenced
this pull request
Sep 13, 2025
littleblack111
added a commit
to littleblack111/helix
that referenced
this pull request
Sep 13, 2025
littleblack111
added a commit
to littleblack111/helix
that referenced
this pull request
Sep 15, 2025
littleblack111
added a commit
to littleblack111/helix
that referenced
this pull request
Sep 16, 2025
littleblack111
added a commit
to littleblack111/helix
that referenced
this pull request
Sep 16, 2025
littleblack111
added a commit
to littleblack111/helix
that referenced
this pull request
Sep 19, 2025
littleblack111
added a commit
to littleblack111/helix
that referenced
this pull request
Sep 23, 2025
littleblack111
added a commit
to littleblack111/helix
that referenced
this pull request
Sep 27, 2025
littleblack111
added a commit
to littleblack111/helix
that referenced
this pull request
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the picker's re-using a few bindings which are also present
in the prompt. This causes some editing behaviours to not function on
the picker.
Ctrl + k and Ctrl + j
This should kill till the end of the line on prompt, but is overridden
by the picker for scrolling. Since there are redundancies (
Ctrl + p,Ctrl + n), we can remove it from picker.Ctrl + f and Ctrl + b
This are used by the prompt for back/forward movement. We could modify
it to be Ctrl + d and Ctrl + u, to match the
vimbehaviour.