Implement bulk buffer closing commands - #1677
Merged
archseer merged 8 commits intoMar 1, 2022
Merged
Conversation
archseer
reviewed
Feb 18, 2022
EpocSquadron
force-pushed
the
epocsquadron/add-buffer-close-all
branch
from
February 19, 2022 04:54
43e6c6f to
b00c196
Compare
Contributor
Author
|
Refactored the buffer close commands to all use shared logic, and rebased. |
archseer
reviewed
Feb 25, 2022
Addresses feedback that accepting an IntoIterator implementor is too much for an internal. Also possibly saves some moving?
EpocSquadron
force-pushed
the
epocsquadron/add-buffer-close-all
branch
from
February 27, 2022 12:57
facceba to
9a94e1d
Compare
Contributor
Author
|
Clippy lint is unrelated to this pull request. |
archseer
approved these changes
Mar 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are convenience methods for cleaning up accumulated buffers as described in #1637.
This could probably be further cleaned up to unify the buffer_close_impl in a way that works for all of the various buffer closing commands, but for now this is effective in my testing. Also I ran out of time, and wanted to get something up. Feel free to rip apart and I'll address later.