fix(commands): don't indent empty lines

[matoous]

Fixes: #1642

[matoous]

Not sure what's the best approach here, initially I was checking that the length of the line is equal to 1 (new line) but that could break for "\r\n". On the other hand, the current approach will skip also lines that already have for example a few spaces (which might be desired).

[sudormrfbin]

Vim indents lines with only whitespace too, but I think it's okay (desirable even) to skip them.

[matoous]

I have the same opinion but wanted to leave it open for discussion.

[kirawi]

You can use doc.text().line(line) to avoid an unwrap.

Also, https://docs.rs/ropey/1.3.2/ropey/struct.RopeSlice.html#method.as_str

For large slices this method will typically fail and return None because large slices usually cross chunk boundaries in the rope.

Overall, I prefer Cow::from(doc.text().line(line)).trim().is_empty()

[archseer]

What about in languages where whitespace indentation is meaningful?

If we only check for empty lines then this could be simplified .line(...).len_chars() == 0

[archseer]

Let's use Cow::from(doc.text().line(line)).trim().is_empty() to avoid the unwrap.

[matoous]

Updated, thanks for the suggestion.

[pickfire]

I think this is better although it is longer, it does not need any allocations.

            if doc.text().line(line).chunks().all(|s| s.trim().is_empty()) {       

[matoous]

Nice, thanks for suggestion, updated.

[archseer]

Seems to still use the old suggestion though