Only pluralise "buffer" when required - #11018
Merged
pascalkuthe merged 2 commits intoJun 26, 2024
Merged
Conversation
thomasschafer
changed the title
the-mikedavis
left a comment
the-mikedavis
left a comment
Member
There was a problem hiding this comment.
Just a tiny consistency nit - elsewhere where we conditionally add the 's' we always check == 1
Contributor
Author
Sounds good - done |
the-mikedavis
approved these changes
Jun 26, 2024
pascalkuthe
approved these changes
Jun 26, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* Only pluralise buffer when required * Use == 1 instead of != 1
mxxntype
pushed a commit
to mxxntype/helix
that referenced
this pull request
Aug 14, 2024
* Only pluralise buffer when required * Use == 1 instead of != 1
kyruzic
pushed a commit
to kyruzic/helix
that referenced
this pull request
Sep 27, 2024
* Only pluralise buffer when required * Use == 1 instead of != 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than showing an error of
n unsaved buffer(s) remaining: ..., we use eitherbufferorbuffersas required.