Skip to content

Handle partial failure when sending textDocument/didSave - #10168

Merged
archseer merged 1 commit into
masterfrom
handle-partial-lsp-did-save-failure
Apr 6, 2024
Merged

Handle partial failure when sending textDocument/didSave#10168
archseer merged 1 commit into
masterfrom
handle-partial-lsp-did-save-failure

Conversation

@the-mikedavis

Copy link
Copy Markdown
Member

One language server being uninitialized or exited should not prevent the other(s) from being notified of didSave.

Fixes #10162

One language server being uninitialized or exited should not prevent
the other(s) from being notified of didSave.
@the-mikedavis the-mikedavis added C-bug Category: This is a bug A-language-server Area: Language server client S-waiting-on-review Status: Awaiting review from a maintainer. labels Apr 5, 2024
@the-mikedavis the-mikedavis self-assigned this Apr 5, 2024
@pascalkuthe

Copy link
Copy Markdown
Member

multi lsp was really a huge change still finding bugs with that after all this time

@archseer
archseer merged commit 3f2de21 into master Apr 6, 2024
@archseer
archseer deleted the handle-partial-lsp-did-save-failure branch April 6, 2024 04:38
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-language-server Area: Language server client C-bug Category: This is a bug S-waiting-on-review Status: Awaiting review from a maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not sending textDocument/didSave notifications to all LSPs

3 participants