Fix --jit=jac crash: CompileJacobian never set nVars/nConsts - #175
Merged
Conversation
…nsts Unlike CompileAVX2, leaving them at their 0 default, tripping JitLMCostFunction::Evaluate's ENSURE for any tree with variables -- --jit=all never hit it since it always falls through to GetOrCompile's merge branch, which backfills them from the residual compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--jit=jac(JIT-compile only the Jacobian, interpreter residuals) crashed for any tree with variables, trippingENSURE(nVars_ < 0 || jacColPtrs_.size() == nVars_)inJitLMCostFunction::Evaluate.Cause:
TreeCompiler::CompileJacobiannever setCompileMeta::nVarsornConstson its result, so both stayed at their default of 0.TreeCompiler::CompileAVX2does set them.--jit=allnever exposed this bug because it always falls through toGetOrCompile, and that function's cache-merge branch backfillsnVars/nConstsfrom the residual compile.--jit=jacnever takes that fallback path, so the zeroed metadata reachedJitLMCostFunctiondirectly.Fix: set
nVarsandnConstsinCompileJacobian, mirroringCompileAVX2.Test plan
./build/test/operon_test '[jit]~[performance]').