Add Automated Root Rotation Parameters to AWS Auth/Secrets and DB Secrets - #2414
Merged
Conversation
vinay-gopalan
marked this pull request as ready for review
March 6, 2025 01:16
vinay-gopalan
requested review from
a team and
biazmoreira
and removed request for
biazmoreira
March 6, 2025 01:16
kpcraig
reviewed
Mar 6, 2025
|
|
||
| import ( | ||
| "context" | ||
| automatedrotationutil "github.com/hashicorp/terraform-provider-vault/internal/rotation" |
Contributor
There was a problem hiding this comment.
maybe it doesn't apply to tfvp, but occasionally some linter somewhere will complain to me about this sort of import order.
kpcraig
previously approved these changes
Mar 6, 2025
robmonte
approved these changes
Mar 6, 2025
robmonte
left a comment
Member
There was a problem hiding this comment.
Looks good, only addition I can think of is a test case that can actually check if a rotation job is registered and that disable_automated_rotation removes the job, and similarly the same result when zeroing out all fields. Don't think we have the support for that level of checking yet though, so something to consider for the future.
kpcraig
approved these changes
Mar 7, 2025
Contributor
Author
|
Will follow up with a docs PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds new automated root rotation parameters that will be available as part of Vault 1.19 Enterprise to the following resources:
vault_aws_secret_backendvault_database_secret_backend_connectionvault_database_secrets_mountvault_aws_auth_backend_clientChecklist
Output from acceptance testing: