Add fields key_usage and serial_number to vault_pki_secret_backend_intermediate_cert_request - #2404
Merged
victorr merged 4 commits intoFeb 10, 2025
Conversation
| } | ||
|
|
||
| func testPkiSecretBackendIntermediateCertRequestConfig_key_usage(path string, optionalKeyUsage string) string { | ||
| var signatureBits string |
Contributor
There was a problem hiding this comment.
Could we collapse all the various clones of this into a single function say testPkiSecretBackendIntermediateCertRequestConfig_generic, and have all these helper functions delegate the tweaked config to it? We have 3-4 copies of this terraform config now.
Contributor
Author
There was a problem hiding this comment.
Good idea, pushed a new changeset.
victorr
deleted the
victorr/vault-33909-intermediate-cert-request-key-usage
branch
February 10, 2025 16:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add fields key_usage and serial_number to vault_pki_secret_backend_intermediate_cert_request
Checklist
Community Note