Skip to content

add iam_tags to vault_aws_secret_backend_role - #2231

Merged
maithyton merged 4 commits into
mainfrom
add-iam-tags-to-aws-secret-backend
May 1, 2024
Merged

add iam_tags to vault_aws_secret_backend_role#2231
maithyton merged 4 commits into
mainfrom
add-iam-tags-to-aws-secret-backend

Conversation

@maithyton

@maithyton maithyton commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

Description

This PR adds iam_tags to vault_aws_secret_backend_role resource, picking up the remaining work on #2087

Closes #1073

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

~/go/src/github.com/hashicorp/terraform-provider-vault (add-iam-tags-to-aws-secret-backend) $ make testacc TESTARGS='-run=TestAccAWSSecretBackendRole'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -run=TestAccAWSSecretBackendRole -timeout 30m ./...
?   	github.com/hashicorp/terraform-provider-vault	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/coverage	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/generate	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/helper	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/consts	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/codegen	0.402s [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/group	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/mfa	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/pki	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/sync	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/schema	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/util/mountutil	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/internal/identity/entity	0.584s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/internal/provider	0.814s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/testutil	1.059s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/util	1.256s [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/vault	0.766s

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@maithyton
maithyton marked this pull request as draft April 30, 2024 19:04
@maithyton
maithyton marked this pull request as ready for review May 1, 2024 06:11
@maithyton
maithyton requested a review from a team May 1, 2024 15:23

@fairclothjm fairclothjm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinay-gopalan vinay-gopalan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests and TF scripts work as expected. Thanks for adding support for this :)

@vinay-gopalan vinay-gopalan added this to the 4.3.0 milestone May 1, 2024
@maithyton

Copy link
Copy Markdown
Contributor Author

Thank you!

@benashz
benashz requested review from benashz and removed request for benashz May 1, 2024 21:13
@maithyton
maithyton merged commit f9a2344 into main May 1, 2024
@maithyton
maithyton deleted the add-iam-tags-to-aws-secret-backend branch May 1, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vault_aws_secret_backend_role doesn't support specifying iam_tags

3 participants