Add state migrator for external_member_group_ids in Identity Group - #2043
Merged
Merged
Conversation
2 tasks
fairclothjm
approved these changes
Oct 9, 2023
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a state migrator for the
external_member_group_idsparameter that was added to the Identity Group resource in v3.10.0. Since the parameter is an internal constant with a default value, it should be set to users' TF configs when they upgrade to the new version. Since it was previously not being set for users upon an upgrade, the regression led to the value beingnullin the TF state. This PR ensures that upon upgrading, if the TF state value isnull, set it to the desired default offalseCloses #1690
Checklist
Output from acceptance testing: