secret/kvv2: fix drift detection when disable_read is enabled - #2039
Merged
Conversation
fairclothjm
force-pushed
the
VAULT-13021/kvv2/disable-read
branch
from
October 9, 2023 14:38
f189c9a to
524681d
Compare
fairclothjm
force-pushed
the
VAULT-13021/kvv2/disable-read
branch
from
October 9, 2023 19:13
524681d to
49af495
Compare
vinay-gopalan
approved these changes
Oct 9, 2023
vinay-gopalan
left a comment
vinay-gopalan
left a comment
Contributor
There was a problem hiding this comment.
LGTM and manual testing also passes 😄 Thanks for working on this!
fairclothjm
force-pushed
the
VAULT-13021/kvv2/disable-read
branch
from
October 9, 2023 20:11
49af495 to
6460721
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug with
disable_readfor the kvv2 secrets resource. Whendisable_readis true we remove the computed data keys from the diff. Otherwise, we will report drift because they were never set but the provider expects them to be because they are computed fields.Closes #1668
Checklist
Output from acceptance testing:
Community Note