Add state migrator in secrets/auth mounts for disable_remount parameter - #2037
Merged
Merged
Conversation
fairclothjm
approved these changes
Oct 3, 2023
disable_remount parameterdisable_remount parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a state upgrader for the
disable_remountparameter that was added to all secrets and auth mounts when enabling mount migration was introduced into the TFVP in #1594. A default offalseis set for new resources, but for resources created using earlier versions of the provider, this field was never properly populated, leading to inconsistent plans and breakages in TF workflows.This PR appropriately populates the field to
falseif it isnilin the TF state.Checklist
Output from acceptance testing: