Add support for roles to both rate limit and lease count quotas - #1994
Conversation
|
This is my first PR to this repo so if I did something wrong here, please let me know 😅 |
fairclothjm
left a comment
There was a problem hiding this comment.
Looking good @raskchanky ! Thanks! Just a few comments
fairclothjm
left a comment
There was a problem hiding this comment.
I forgot to mention the Import test step the last time around. Sorry about that! Otherwise LGTM! Thanks!
vinay-gopalan
left a comment
There was a problem hiding this comment.
Thanks for working through this! Apologies for the longer comments, these are definitely more nuanced bits of the TFVP so wanted to take a sec to be more descriptive! Happy to answer any more questions if needed :)
|
@vinay-gopalan Thank you so much for all the comments! Never apologize for too much information. This is terrific stuff, particularly for someone like me that's so new to this code. I appreciate all the time you took to write all this up. |
|
@vinay-gopalan @fairclothjm Anything else to do here or is this good to merge? |
This adds support for the
roleattribute for both rate limit and lease count quotas.Closes #1782
Community Note
Release note for CHANGELOG:
Output from acceptance testing: