Skip to content

Add support for multi-issuer functionality to PKI - #1910

Merged
vinay-gopalan merged 16 commits into
mainfrom
VAULT-5960/pki-multi-issuer
Jun 20, 2023
Merged

Add support for multi-issuer functionality to PKI#1910
vinay-gopalan merged 16 commits into
mainfrom
VAULT-5960/pki-multi-issuer

Conversation

@vinay-gopalan

Copy link
Copy Markdown
Contributor

This PR adds the necessary resources and data sources to support the multi-issuer flow in the PKI engine. This PR also contains the relevant documentation and tests for the resources and datasources added.

vinay-gopalan and others added 13 commits May 4, 2023 14:22
…rraform-provider-vault into VAULT-5960/pki-multi-issuer
* secret/pki: add issuer_ref field

* add test cases

* add docs

* simplify test checks
)

* use context methods and consts

* use loops for fields in create method

* use loops for update and read; handle special cases

* rearrange code for consistency and add comments for posterity

* add comment about adding new fields

* fix comment

* remove use of Exists field and function
* pki/secrets: add allowed_uri_sans_template field to role resource

* add allow_wildcard_certificates field

* fix name of new field
@vinay-gopalan
vinay-gopalan requested review from a team and fairclothjm June 20, 2023 15:46

@raymonstah raymonstah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@fairclothjm fairclothjm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants