add role resource + test - #1816
Merged
Merged
Conversation
vinay-gopalan
left a comment
vinay-gopalan
left a comment
Contributor
There was a problem hiding this comment.
Looking great so far! Had some initial comments; thanks for working on this! 😄
Zlaticanin
commented
Apr 10, 2023
Zlaticanin
marked this pull request as ready for review
April 12, 2023 16:38
vinay-gopalan
left a comment
vinay-gopalan
left a comment
Contributor
There was a problem hiding this comment.
Looking great! Could we also include the docs in this PR?
vinay-gopalan
left a comment
vinay-gopalan
left a comment
Contributor
There was a problem hiding this comment.
Looking great! Had some comments, a few of which have been scoped under this PR. Let me know what you think!
| of the form: `<mount_path>/roles/<role_name>` e.g. | ||
|
|
||
| ``` | ||
| $ terraform import vault_mongodbatlas_secret_role.example mongodbatlas/roles/example-role |
Contributor
There was a problem hiding this comment.
Suggested change
| $ terraform import vault_mongodbatlas_secret_role.example mongodbatlas/roles/example-role | |
| $ terraform import vault_mongodbatlas_secret_role.role mongodbatlas/roles/example-role |
vinay-gopalan
approved these changes
Apr 14, 2023
vinay-gopalan
left a comment
vinay-gopalan
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for working on this 🙏🏼
Contributor
Author
|
@vinay-gopalan Thank you so much for the reviews and help! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2/2 Second part of adding TFVP support for MongoDB Atlas secrets engine.