Skip to content

Add support for login MFA resources - #1620

Merged
benashz merged 10 commits into
mainfrom
VAULT-6034/support-login-mfa
Oct 4, 2022
Merged

Add support for login MFA resources#1620
benashz merged 10 commits into
mainfrom
VAULT-6034/support-login-mfa

Conversation

@benashz

@benashz benashz commented Sep 28, 2022

Copy link
Copy Markdown
Collaborator

This PR adds support for the Login MFA methods: duo, okta, pingid, totp.

It also adds support for configuring Login MFA enforcement.

Closes #1431

@benashz
benashz force-pushed the VAULT-6034/support-login-mfa branch from 7718f05 to ecbfa30 Compare September 28, 2022 19:48
@benashz
benashz force-pushed the VAULT-6034/support-login-mfa branch from ecbfa30 to dba4d79 Compare September 28, 2022 19:54
@benashz
benashz force-pushed the VAULT-6034/support-login-mfa branch from 7c9e56f to 8156efe Compare September 29, 2022 21:35
@benashz benashz added this to the 3.9.0 milestone Sep 30, 2022

@vinay-gopalan vinay-gopalan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Had a couple of comments/questions
Ready to approve after docs are in!

Comment thread internal/identity/mfa/mfa.go Outdated
Comment thread vault/resource_identity_mfa_duo_test.go Outdated
- obsolete schema.go
- address review feedback
@benashz
benashz requested a review from vinay-gopalan October 4, 2022 16:46

@vinay-gopalan vinay-gopalan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@benashz
benashz merged commit 810708c into main Oct 4, 2022
@benashz
benashz deleted the VAULT-6034/support-login-mfa branch October 4, 2022 19:36
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Login MFA

2 participants